New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: allow disable search on collection #1236

Merged

arnaud-moncel merged 6 commits into main from feat/allow-disable-search

Jan 13, 2025

Member

arnaud-moncel commented Dec 27, 2024

Definition of Done

General

Write an explicit title for the Pull Request, following Conventional Commits specification
Test manually the implemented changes
Validate the code quality (indentation, syntax, style, simplicity, readability)

Security

Consider the security impact of the changes made

arnaud-moncel added 4 commits

December 27, 2024 16:16


          feat: allow disable search on collection

004eef5


          fix: use the last config of the builder


          fix: mark schema as dirty

16a5f33


          test: add test

88e85e0

jeffladiray reviewed

View reviewed changes

packages/datasource-customizer/test/decorators/search/collections.test.ts Outdated Show resolved Hide resolved

packages/datasource-customizer/test/decorators/search/collections.test.ts

                 describe('refineSchema', () => {
                   it('should set the schema searchable', async () => {
                     const decorator = buildCollection({ searchable: false });
                     expect(decorator.schema.searchable).toBe(true);
                   });
+                  describe('when replace and disable are both used', () => {

Member

jeffladiray Jan 10, 2025

Insane ♡

packages/datasource-customizer/test/decorators/search/collections.test.ts Outdated Show resolved Hide resolved


          fix: reveiw

2272ef3

jeffladiray self-requested a review

January 13, 2025 13:28

jeffladiray requested changes

View reviewed changes

packages/datasource-customizer/src/collection-customizer.ts Show resolved Hide resolved


          fix: add jsdoc

arnaud-moncel requested a review from jeffladiray

January 13, 2025 13:30

codeclimate bot commented Jan 13, 2025

Code Climate has analyzed commit 8174661 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (98% is the threshold).

This pull request will bring the total coverage in the repository to 97.2% (0.0% change).

View more on Code Climate.

jeffladiray approved these changes

View reviewed changes

arnaud-moncel merged commit c9e5e67 into main

22 checks passed

arnaud-moncel deleted the feat/allow-disable-search branch

January 13, 2025 16:31

forest-bot added a commit that referenced this pull request


          chore(release): [email protected] [skip ci]

1a4fd90

## [1.12.5](https://github.com/ForestAdmin/agent-nodejs/compare/[email protected]@1.12.5) (2025-01-13)

### Features

* allow disable search on collection ([#1236](#1236)) ([c9e5e67](c9e5e67))

forest-bot added a commit that referenced this pull request


          chore(release): @forestadmin/[email protected] [skip ci]

66a557d

## [1.57.1](https://github.com/ForestAdmin/agent-nodejs/compare/@forestadmin/[email protected]...@forestadmin/[email protected]) (2025-01-13)

### Features

* allow disable search on collection ([#1236](#1236)) ([c9e5e67](c9e5e67))

Member

forest-bot commented Jan 13, 2025

🎉 This PR is included in version 1.12.16 🎉

The release is available on npm package (@latest dist-tag)

Your semantic-release bot 📦🚀

forest-bot added a commit that referenced this pull request


          chore(release): @forestadmin/[email protected] [skip ci]

f9e2d95

# [1.59.0](https://github.com/ForestAdmin/agent-nodejs/compare/@forestadmin/[email protected]...@forestadmin/[email protected]) (2025-01-13)

### Features

* allow disable search on collection ([#1236](#1236)) ([c9e5e67](c9e5e67))

forest-bot added the released label

forest-bot added a commit that referenced this pull request


          chore(release): @forestadmin/[email protected] [skip ci]

8c171f8

## [1.1.45](https://github.com/ForestAdmin/agent-nodejs/compare/@forestadmin/[email protected]...@forestadmin/[email protected]) (2025-01-13)

### Features

* allow disable search on collection ([#1236](#1236)) ([c9e5e67](c9e5e67))

Member

forest-bot commented Jan 13, 2025

🎉 This PR is included in version 1.12.5 🎉

The release is available on [email protected]

Your semantic-release bot 📦🚀

forest-bot added a commit that referenced this pull request


          chore(release): @forestadmin/[email protected] [skip ci]

## [1.4.13](https://github.com/ForestAdmin/agent-nodejs/compare/@forestadmin/[email protected]...@forestadmin/[email protected]) (2025-01-13)

### Features

* allow disable search on collection ([#1236](#1236)) ([c9e5e67](c9e5e67))

forest-bot added a commit that referenced this pull request


          chore(release): @forestadmin/[email protected] [skip ci]

053f1b6

## [1.1.19](https://github.com/ForestAdmin/agent-nodejs/compare/@forestadmin/[email protected]...@forestadmin/[email protected]) (2025-01-13)

### Features

* allow disable search on collection ([#1236](#1236)) ([c9e5e67](c9e5e67))

Member

forest-bot commented Jan 13, 2025

🎉 This PR is included in version 1.57.1 🎉

The release is available on npm package (@latest dist-tag)

Your semantic-release bot 📦🚀

forest-bot added a commit that referenced this pull request


          chore(release): @forestadmin/[email protected] [skip ci]

681d026

## [1.4.3](https://github.com/ForestAdmin/agent-nodejs/compare/@forestadmin/[email protected]...@forestadmin/[email protected]) (2025-01-13)

### Features

* allow disable search on collection ([#1236](#1236)) ([c9e5e67](c9e5e67))

Member

forest-bot commented Jan 13, 2025

🎉 This PR is included in version 1.59.0 🎉

The release is available on npm package (@latest dist-tag)

Your semantic-release bot 📦🚀

Member

forest-bot commented Jan 13, 2025

🎉 This PR is included in version 1.1.45 🎉

The release is available on npm package (@latest dist-tag)

Your semantic-release bot 📦🚀

Member

forest-bot commented Jan 13, 2025

🎉 This PR is included in version 1.5.10 🎉

The release is available on npm package (@latest dist-tag)

Your semantic-release bot 📦🚀

Member

forest-bot commented Jan 13, 2025

🎉 This PR is included in version 1.4.13 🎉

The release is available on npm package (@latest dist-tag)

Your semantic-release bot 📦🚀

Member

forest-bot commented Jan 13, 2025

🎉 This PR is included in version 1.1.19 🎉

The release is available on npm package (@latest dist-tag)

Your semantic-release bot 📦🚀

Member

forest-bot commented Jan 13, 2025

🎉 This PR is included in version 1.4.3 🎉

The release is available on npm package (@latest dist-tag)

Your semantic-release bot 📦🚀

forest-bot added a commit that referenced this pull request


          chore(release): @forestadmin/[email protected] [skip ci]

88ff5b7

## [1.8.10](https://github.com/ForestAdmin/agent-nodejs/compare/@forestadmin/[email protected]...@forestadmin/[email protected]) (2025-01-22)

### Features

* allow disable search on collection ([#1236](#1236)) ([c9e5e67](c9e5e67))
* upgrade uuid package to handle uuid v7 ([#1243](#1243)) ([ebf9515](ebf9515))

Member

forest-bot commented Jan 22, 2025

🎉 This PR is included in version 1.3.31 🎉

The release is available on npm package (@latest dist-tag)

Your semantic-release bot 📦🚀

forest-bot added a commit that referenced this pull request


          chore(release): @forestadmin/[email protected] [skip ci]

8f7f8e2

## [1.11.5](https://github.com/ForestAdmin/agent-nodejs/compare/@forestadmin/[email protected]...@forestadmin/[email protected]) (2025-01-22)

### Features

* allow disable search on collection ([#1236](#1236)) ([c9e5e67](c9e5e67))
* upgrade uuid package to handle uuid v7 ([#1243](#1243)) ([ebf9515](ebf9515))

forest-bot added a commit that referenced this pull request


          chore(release): @forestadmin/[email protected] [skip ci]

aa97e5f

## [1.16.5](https://github.com/ForestAdmin/agent-nodejs/compare/@forestadmin/[email protected]...@forestadmin/[email protected]) (2025-01-22)

### Features

* allow disable search on collection ([#1236](#1236)) ([c9e5e67](c9e5e67))
* upgrade uuid package to handle uuid v7 ([#1243](#1243)) ([ebf9515](ebf9515))

forest-bot added a commit that referenced this pull request


          chore(release): @forestadmin/[email protected] [skip ci]

be70958

# [1.47.0](https://github.com/ForestAdmin/agent-nodejs/compare/@forestadmin/[email protected]...@forestadmin/[email protected]) (2025-01-22)

### Features

* allow disable search on collection ([#1236](#1236)) ([c9e5e67](c9e5e67))
* upgrade uuid package to handle uuid v7 ([#1243](#1243)) ([ebf9515](ebf9515))

forest-bot added a commit that referenced this pull request


          chore(release): @forestadmin/[email protected] [skip ci]

826e922

## [1.36.4](https://github.com/ForestAdmin/agent-nodejs/compare/@forestadmin/[email protected]...@forestadmin/[email protected]) (2025-01-22)

### Features

* allow disable search on collection ([#1236](#1236)) ([c9e5e67](c9e5e67))
* upgrade uuid package to handle uuid v7 ([#1243](#1243)) ([ebf9515](ebf9515))

Member

forest-bot commented Jan 22, 2025

🎉 This PR is included in version 1.8.10 🎉

The release is available on npm package (@latest dist-tag)

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels